[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Trivial fix on an argument in ftpfs
|
From: |
Anders Juel Jensen |
|
Subject: |
Re: [PATCH] Trivial fix on an argument in ftpfs |
|
Date: |
Fri, 29 Jul 2005 22:25:03 +0000 |
hi again,
Alfred requested to see "proof" that there really is a bug here.
So this is just for you :-)
(btw, check ihash.h if you want to know why i am so sure)
Attaching to program `/home/macavity/hurd/ftpfs', pid 26673
Reading symbols from /home/macavity/lib/libhurdbugaddr.so.0.3...done.
Loaded symbols for /home/macavity/lib/libhurdbugaddr.so.0.3
Reading symbols from /home/macavity/lib/libnetfs.so.0.3...done.
Loaded symbols for /home/macavity/lib/libnetfs.so.0.3
Reading symbols from /home/macavity/lib/libfshelp.so.0.3...done.
Loaded symbols for /home/macavity/lib/libfshelp.so.0.3
Reading symbols from /home/macavity/lib/libiohelp.so.0.3...done.
Loaded symbols for /home/macavity/lib/libiohelp.so.0.3
Reading symbols from /home/macavity/lib/libthreads.so.0.3...done.
Loaded symbols for /home/macavity/lib/libthreads.so.0.3
Reading symbols from /home/macavity/lib/libports.so.0.3...done.
Loaded symbols for /home/macavity/lib/libports.so.0.3
Reading symbols from /home/macavity/lib/libihash.so.0.3...done.
Loaded symbols for /home/macavity/lib/libihash.so.0.3
Reading symbols from /home/macavity/lib/libftpconn.so.0.3...done.
Loaded symbols for /home/macavity/lib/libftpconn.so.0.3
Reading symbols from /home/macavity/lib/libshouldbeinlibc.so.0.3...done.
Loaded symbols for /home/macavity/lib/libshouldbeinlibc.so.0.3
Reading symbols from /lib/libc.so.0.3...done.
Loaded symbols for /lib/libc.so.0.3
Reading symbols from /lib/libmachuser.so.1...done.
Loaded symbols for /lib/libmachuser.so.1
Reading symbols from /lib/libhurduser.so.0.3...done.
Loaded symbols for /lib/libhurduser.so.0.3
Reading symbols from /lib/ld.so...done.
Loaded symbols for /lib/ld.so
Reading symbols from /lib/libnss_files.so.2...done.
Loaded symbols for /lib/libnss_files.so.2
Reading symbols from /lib/libnss_dns.so.2...done.
Loaded symbols for /lib/libnss_dns.so.2
Reading symbols from /lib/libresolv.so.2...done.
Loaded symbols for /lib/libresolv.so.2
(gdb) continue
Continuing.
warning: Can't wait for pid 26673: No child processes
Program received signal EXC_BAD_ACCESS, Could not access memory.
[Switching to thread 26673.4]
hurd_ihash_locp_remove (ht=0x804e5c4, locp=0x0) at
../../hurd/libihash/ihash.c:160
160 *locp = _HURD_IHASH_DELETED;
(gdb) bt full
#0 hurd_ihash_locp_remove (ht=0x804e5c4, locp=0x0) at
../../hurd/libihash/ihash.c:160
No locals.
#1 0x0804d45c in netfs_node_norefs (node=0x8050cf0) at
../../hurd/ftpfs/node.c:95
nn = (struct netnode *) 0x804e6e0
#2 0x010283e0 in netfs_drop_node (np=0x8050cf0) at
../../hurd/libnetfs/drop-node.c:27
No locals.
#3 0x010311f5 in netfs_nrele (np=0x8050cf0) at ../../hurd/libnetfs/nrele.c:32
No locals.
#4 0x0804d5b9 in ftpfs_cache_node (node=0x8067118) at
../../hurd/ftpfs/ncache.c:82
lru = (struct node *) 0x8067118
nn = (struct netnode *) 0x8050cf0
fs = (struct ftpfs *) 0x804e5a0
#5 0x0804b779 in ftpfs_refresh_node (node=0x8067118) at
../../hurd/ftpfs/dir.c:548
err = 0
timestamp = 0
dir = (struct ftpfs_dir *) 0x8066500
nn = (struct netnode *) 0x8067028
entry = (struct ftpfs_dir_entry *) 0x8067060
#6 0x01027897 in netfs_S_dir_lookup (diruser=0x804f768, filename=0x0, flags=0,
mode=0, do_retry=0x126df54,
retry_name=0x126df5c "", retry_port=0x126e360, retry_port_type=0x126be20)
at ../../hurd/libnetfs/dir-lookup.c:182
create = 0
excl = 0
mustbedir = 0
lastcomp = 1
newnode = 0
nsymlinks = 0
dnp = (struct node *) 0x80663e0
np = (struct node *) 0x8067118
nextname = 0x0
error = 0
newpi = (struct protid *) 0x804f6f0
user = (struct iouser *) 0x2
#7 0x0102b5d8 in _Xdir_lookup (InHeadP=0x804f768, OutHeadP=0x126df30) at
fsServer.c:1519
file_nameCheck = {msgt_name = 12, msgt_size = 8, msgt_number = 1024,
msgt_inline = 1, msgt_longform = 0,
msgt_deallocate = 0, msgt_unused = 0}
flagsCheck = {msgt_name = 2, msgt_size = 32, msgt_number = 1,
msgt_inline = 1, msgt_longform = 0,
msgt_deallocate = 0, msgt_unused = 0}
modeCheck = {msgt_name = 2, msgt_size = 32, msgt_number = 1,
msgt_inline = 1, msgt_longform = 0,
msgt_deallocate = 0, msgt_unused = 0}
---Type <return> to continue, or q <return> to quit---
do_retryType = {msgt_name = 2, msgt_size = 32, msgt_number = 1,
msgt_inline = 1, msgt_longform = 0,
msgt_deallocate = 0, msgt_unused = 0}
retry_nameType = {msgt_name = 12, msgt_size = 8, msgt_number = 1024,
msgt_inline = 1, msgt_longform = 0,
msgt_deallocate = 0, msgt_unused = 0}
resultType = {msgt_name = 255, msgt_size = 32, msgt_number = 1,
msgt_inline = 1, msgt_longform = 0,
msgt_deallocate = 0, msgt_unused = 0}
resultPoly = 20
#8 0x01029e31 in netfs_fs_server (InHeadP=0x126bf20, OutHeadP=0x0) at
fsServer.c:2680
RetCodeType = {msgt_name = 2, msgt_size = 32, msgt_number = 1,
msgt_inline = 1, msgt_longform = 0,
msgt_deallocate = 0, msgt_unused = 0}
routine = 0
#9 0x0102739c in netfs_demuxer (inp=0x126bf20, outp=0x126df30) at
../../hurd/libnetfs/demuxer.c:38
No locals.
#10 0x01044dd4 in internal_demuxer.0 () at
../../hurd/libports/manage-multithread.c:101
No locals.
#11 0x0107dcfc in mach_msg_server_timeout () from /lib/libc.so.0.3
No symbol table info available.
#12 0x01044ef2 in thread_function.1 () at
../../hurd/libports/manage-multithread.c:136
No locals.
#13 0x0103e878 in cthread_body (self=0x80514a0) at
../../hurd/libthreads/cthreads.c:306
t = 0x8050e40
#14 0x00000000 in ?? ()
No symbol table info available.
(gdb) list
306 t->result = (*(t->func))(t->arg);
307 }
308 /*
309 * Return result from thread.
310 */
311 TRACE(printf("[%s] done()\n", cthread_name(t)));
312 mutex_lock(&t->lock);
313 if (t->state & T_DETACHED) {
314 mutex_unlock(&t->lock);
315 cthread_free(t);
On Fri, 29 Jul 2005 17:39:30 +0000
Anders Juel Jensen <ajjensen@hotpop.com> wrote:
> Hi.
> Just a small fix in ftpfs, it was probably just a typo in the first
> place.
>
> ~Anders Juel Jensen (aka macavity on IRC)
>
> PS.: Thanks to hde, bing, youpi, antrik and marco_g for putting up with
> all my newbe questions. It motivates me a lot when people bother to
> invest their time in me.
>
>
> 2005-07-29 Anders Juel Jensen <ajjensen@hotpop.com>
>
> * node.c (netfs_node_norefs) <hurd_ihash_locp_remove>:
> Adding missing dereference of an argument.
>
>
> RCS file: /cvsroot/hurd/hurd/ftpfs/node.c,v
> retrieving revision 1.2
> diff -u -r1.2 node.c
> --- ftpfs/node.c 1 Mar 2004 09:58:44 -0000 1.2
> +++ ftpfs/node.c 29 Jul 2005 15:39:00 -0000
> @@ -92,7 +92,7 @@
>
> /* Remove this entry from the set of known inodes. */
> spin_lock (&nn->fs->inode_mappings_lock);
> - hurd_ihash_locp_remove (&nn->fs->inode_mappings, nn->dir_entry-
> >inode_locp);
> + hurd_ihash_locp_remove (&nn->fs->inode_mappings, &nn->dir_entry-
> >inode_locp); spin_unlock (&nn->fs->inode_mappings_lock);
>
> if (nn->contents)
>
>
>
>
> _______________________________________________
> Bug-hurd mailing list
> Bug-hurd@gnu.org
> http://lists.gnu.org/mailman/listinfo/bug-hurd