Re: patch to close task #1017

[Thomas Schwinge]

On Fri, Aug 05, 2005 at 08:47:25PM +0200, Alfred M. Szmidt wrote:
> hurd/ChangeLog
> 2005-08-05  Alfred M. Szmidt  <ams@gnu.org>
> 
>       * Makefile (MSGIDS): New variable.
>       (all): New target.
>       (install-headers, install): Depend on `install-msgids'.
>       (install-msgids): New target
>       ($(datadir)/msgids): New target.

> --- hurd/Makefile     22 Aug 2002 23:25:04 +0200      1.28
> +++ hurd/Makefile     05 Aug 2005 20:44:20 +0200      
> [...]
>  install-headers install: $(includedir)/hurd \
> -     $(addprefix $(includedir)/hurd/,$(INSTHDRS))
> +     $(addprefix $(includedir)/hurd/,$(INSTHDRS)) install-msgids

I'd suggest to leave out that change and instead use something like
#v+
install: install-msgids
#v-

Installing the msgids alongside the headers yields no real benefit, but
makes cross compilations harder:

#v+
[...]
/command/install -c -m 644 /var/tmp/gnu-4/src/hurd/hurd/term.defs 
/var/tmp/gnu-4/sys_root/include/hurd/term.defs
/command/install -c -m 644 /var/tmp/gnu-4/src/hurd/hurd/tioctl.defs 
/var/tmp/gnu-4/sys_root/include/hurd/tioctl.defs
if grep -q '^subsystem' /var/tmp/gnu-4/src/hurd/hurd/auth.defs; \
then gcc -E -x c  -I. -I/var/tmp/gnu-4/src/hurd/hurd -I.. 
-I/var/tmp/gnu-4/src/hurd -I../include -I/var/tmp/gnu-4/src/hurd/include 
-D_GNU_SOURCE -D_IO_MTSAFE_IO -D_FILE_OFFSET_BITS=64  -DPACKAGE_NAME=\"\" 
-DPACKAGE_TARNAME=\"\" -DPACKAGE_VERSION=\"\" -DPACKAGE_STRING=\"\" 
-DPACKAGE_BUGREPORT=\"\" -DHAVE_MIG_RETCODE=1 -DHAVE_GETGROUPLIST=1 
-DHAVE_USELOCALE=1  /var/tmp/gnu-4/src/hurd/hurd/auth.defs | i586-pc-gnu-mig 
-cc cat - /dev/null -n -list auth.msgids; \
else > auth.msgids; fi
In file included from /var/tmp/gnu-4/src/hurd/hurd/auth.defs:22:
/var/tmp/gnu-4/src/hurd/hurd/hurd_types.defs:21:31: mach/std_types.defs: No 
such file or directory
/var/tmp/gnu-4/src/hurd/hurd/hurd_types.defs:22:32: mach/mach_types.defs: No 
such file or directory
/var/tmp/gnu-4/src/hurd/hurd/hurd_types.defs:23:36: device/device_types.defs: 
No such file or directory
"/var/tmp/gnu-4/src/hurd/hurd/hurd_types.defs", line 24: type 
'mach_port_copy_send_t' not defined
[...]
"/var/tmp/gnu-4/src/hurd/hurd/hurd_types.defs", line 159: type 
'mach_port_copy_send_t' not defined
"/var/tmp/gnu-4/src/hurd/hurd/hurd_types.defs", line 204: type 'char' not 
defined
/var/tmp/gnu-4/bin/i586-pc-gnu-mig: line 132: 28266 Done                    cat 
- /dev/null
     28267 Floating point exception| /var/tmp/gnu-4/libexec/i586-pc-gnu-migcom 
-n -list auth.msgids
make[1]: *** [auth.msgids] Error 136
make[1]: Leaving directory `/fs/data/mount/tmp/gnu-4/src/hurd.obj/hurd'
make: *** [hurd-install-headers] Error 2
#v-

> +install-msgids: $(MSGIDS); $(INSTALL_DATA) $^ $(datadir)/msgids

That line should read (already reported to Alfred)
#v+
install-msgids: $(MSGIDS) $(datadir)/msgids; $(INSTALL_DATA) $^
#v-


Regards,
 Thomas