Re: gnumach, device params

[Gianluca Guida]

On 1/8/06, Samuel Thibault <samuel.thibault@ens-lyon.org> wrote:
> Alfred M. Szmidt, le Sun 08 Jan 2006 17:57:27 +0100, a écrit :
> > Looks ok.  Why the ifdef i386 though?

Because this patch assumes the i386 device emulation that Mach's i386
subsection uses. That is actually architecture independent, and for
example I removed it in latest stomach tree.

> Cf all ifdef i386 along device/ds_routines.c for instance.  I don't know
> the deep reason for all these defines, it's another issue anyway.

device/ is not in the i386 subtree, so activating it only when
compiling for i386 is the reason. As  I said, the device emulation
stuff, that is a rough hack to skip and make unuseful almost all of
the device/'s subsection code, is compiled only in i386.

In this patch, the #ifdef i386 is unuseful, since you are compiling in
the i386 subsection.

I am not actually happy with this patch, since it will break for
example stomach, and since I guess it's trying to fix an error on the
callers (that should give the proper parameter) by modifying the
called function.

G.


--
It was a type of people I did not know, I found them very strange and
they did not inspire confidence at all. Later I learned that I had been
introduced to electronic engineers.
                                                  E. W. Dijkstra