[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: gnumach and gcc 4.0 (patch 1)
From: |
Thomas Schwinge |
Subject: |
Re: gnumach and gcc 4.0 (patch 1) |
Date: |
Sun, 22 Jan 2006 10:57:30 -0500 |
User-agent: |
Mutt/1.5.6+20040523i |
On Fri, Jan 20, 2006 at 11:45:09PM -0500, Marcus Brinkmann wrote:
> Just a general comment: If you commit a change, the date in the
> ChangeLog should be the date of the commit, not the date when the patch
> was written or submitted. I certainly didn't use to do it, so you will
> find wrong precedence, but the FSF stated this policy a while ago.
Yes, I inteded to do (and have done) that at the time I commit the patch.
> > How do people feel about commiting the NIC update patch
> > (e.g.
> > <URL:http://svn.debian.org/wsvn/pkg-hurd/gnumach/trunk/debian/patches/11_nic_update.patch?op=file&rev=0&sc=0>;
> > I can send a inline copy if someone wants to have a look at it.)
It now finally found his way into CVS. I only left out the two files
`pci-serial.c' and `pci-skeleton.c', which don't contain NIC driver code.
> If it got sufficient testing by people who actually such cards (not all
> cards, just some of them :) then yes, I think it can go in.
Yes, this field testing has happened.
> As a matter
> of routine, personally I would go and check if the files that are taken
> from third parties are actually original copies of the versions as
> stated in the ChangeLog.
Yes, I've done that.
Regards,
Thomas