Re: OT: Fixed Roland'd Hurd EA ext2 patch for Linux

[Michael Banck]

On Sun, Jan 29, 2006 at 12:42:22PM +0100, Alfred M. Szmidt wrote:
> It would be a pitty if users had to recompile their kernel to have
> this supported, is there any possibility of including this in Linux?

I hope Roland will submit this upstream once this has been tested a bit
more.  I will roll Debian/Ubuntu kernels next week and announce them
here.

For what's it worth, this is the code change compared to Roland's last
version:

diff -u linux-2.6/fs/ext2/xattr.c linux-2.6/fs/ext2/xattr.c
--- linux-2.6/fs/ext2/xattr.c
+++ linux-2.6/fs/ext2/xattr.c
@@ -337,9 +337,9 @@
                                } else {
                                        memcpy(buffer, name, size);
                                        buffer += size;
-                                       rest -= size;
                                }
                        }
+                       rest -= size;
                }
                if (ei->i_hurd_translator != 0) {
                        name = "gnu.translator";
@@ -350,9 +350,9 @@
                                } else {
                                        memcpy(buffer, name, size);
                                        buffer += size;
-                                       rest -= size;
                                }
                        }
+                       rest -= size;
                }
                if (error >= 0)
                        error = buffer_size - rest;  /* total size */