bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Warnings removed from linux/dev/drivers/block/genhd.c


From: Alfred M. Szmidt
Subject: Re: Warnings removed from linux/dev/drivers/block/genhd.c
Date: Tue, 31 Jan 2006 01:55:21 +0100

   >    Are you sure that changing the #ifdef to #if is the right
   >    change?
   > 
   > Quite, if you have specific concerns that I might have missed
   > then please speak up.

   Your patch is potentially a functional change; not simply a bug fix.
   You've defended the addition of CONFIG_BSD_DISKLABEL but not the
   change from #ifdef to #if.

If you have specific concerns around it, please state them.  You have
not done so.  If you prefer `#if defined (foo) && defined (bar)', that
is fine too.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]