|
| From: | Neal H. Walfield |
| Subject: | Re: Warnings removed from linux/dev/drivers/block/genhd.c |
| Date: | Tue, 31 Jan 2006 01:51:46 +0100 |
| User-agent: | Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.6 (Marutamachi) APEL/10.6 Emacs/21.4 (i386-pc-linux-gnu) MULE/5.0 (SAKAKI) |
At Tue, 31 Jan 2006 01:23:02 +0100, Alfred M. Szmidt wrote: > > Are you sure that changing the #ifdef to #if is the right change? > > Quite, if you have specific concerns that I might have missed then > please speak up. Your patch is potentially a functional change; not simply a bug fix. You've defended the addition of CONFIG_BSD_DISKLABEL but not the change from #ifdef to #if.
| [Prev in Thread] | Current Thread | [Next in Thread] |