Re: [patch] ISA-support in GNU Mach PCMCIA core

[Thomas Schwinge]

Hello!

On Mon, Aug 28, 2006 at 03:26:55AM +0200, Stefan Siegl wrote:
> The patch along adds yet another configure option (enable-pcmcia-isa),
> allowing to compile that bits in. The latter is especially useful if
> your PCMCIA bridge, attached to the PCI bus, doesn't get an IRQ itself.
> In this case the PCMCIA core does not know which IRQ to assign unless an
> (ISA) IRQ scan takes place.

Please add a short snippet to i386/README-Drivers as well and then commit
the whole lot; the ChangeLog addition should perhaps look like this:

[current date]  Stefan Siegl  <stesie@brokenpipe.de>

        * i386/linux/configure: Regenerate.
        * i386/linux/device-drivers.h.in: Likewise.

        * i386/linux/configure.ac (AC_PCMCIA_OPTION): New function.
        (--enable-pcmcia-isa): New configuration option to enable ISA-bus
        support in the pcmcia core.
        * doc/mach.texi (Configuration): Briefly document the new configuration
        option.
        * i386/README-Drivers: Likewise.

... compared to yours:

> 2006-08-28  Stefan Siegl  <stesie@brokenpipe.de>
> 
>       * i386/linux/configure.ac: Add configuration option allowing to enable
>       ISA-bus support in the pcmcia core.
> 
>       * i386/linux/configure: Regenerate.
>       * i386/linux/device-drivers.h.in: Likewise.
> 
>       * doc/mach.texi (Configuration): Briefly document the new configuration
>       option.

This means: group together (i.e. without new-lines in between) stuff that
belongs together (the new option and its documentation) and
(chronologically) _after_ that (which will be _above_ in the ChangeLog)
the regeneration of the compiled files.  You could even do the actual
patch and the regeneration of the files as separate commits (also to make
sure that the regenerated files have more recent time stamps -- no idea
if cvs deals with that correctly otherwise).


Regards,
 Thomas

signature.asc
Description: Digital signature