[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: gnumach ChangeLog i386/i386/gdt.h i386/i386/pcb... [gnumach-1-branch
From: |
Thomas Schwinge |
Subject: |
Re: gnumach ChangeLog i386/i386/gdt.h i386/i386/pcb... [gnumach-1-branch] |
Date: |
Sun, 5 Nov 2006 23:10:44 +0100 |
User-agent: |
Mutt/1.5.6+20040907i |
Hello!
On Sun, Nov 05, 2006 at 10:58:12PM +0100, Samuel Thibault wrote:
> Samuel Thibault, le Sun 05 Nov 2006 22:49:59 +0100, a ?crit :
> > Roland McGrath, le Sun 05 Nov 2006 13:41:43 -0800, a ?crit :
> > > > - else if (thread == current_thread()) {
> > > > - struct x86_desc template = {0, 0, 0, ACC_P, 0, 0 ,0};
> > > > + else {
> > > > + struct real_descriptor template = {0, 0, 0, ACC_P, 0, 0
> > > > ,0};
> > >
> > > This can't be right (changing the if).
> >
> > Uh, didn't notice that. Barry, do you remember why you dropped the if?
>
> That's actually not from Barry's patch (the code above deals with LDT,
> not GDT), but from Jeroen's.
Ah, right.
#v+
2006-01-26 Jeroen Dekkers <jeroen@dekkers.cx>
* i386/i386/locore.S (trap_push_segs): Switch fs and gs to kernel
data segment too.
(syscall_entry_2): Likewise.
* i386/i386/user_ldt.c (i386_set_ldt): Always copy the master LDT
when there is no old user LDT.
#v-
So, I guess we want to keep this installed? We installed it that that
time, because it prevented GNU Mach from crashing when using the `ld.so'
of a tls enabled glibc.
Regards,
Thomas
signature.asc
Description: Digital signature
Re: gnumach ChangeLog i386/i386/gdt.h i386/i386/pcb... [gnumach-1-branch], Samuel Thibault, 2006/11/05