[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Gnumach cleanup Round 6
From: |
Thomas Bushnell BSG |
Subject: |
Re: Gnumach cleanup Round 6 |
Date: |
Wed, 15 Nov 2006 12:48:53 -0800 |
On Wed, 2006-11-15 at 13:43 -0500, Barry deFreese wrote:
> Hi folks, it's your favorite PITA again.. :-)
> Index: i386/i386/trap.c
> ===================================================================
> RCS file: /cvsroot/hurd/gnumach/i386/i386/trap.c,v
> retrieving revision 1.5.2.6
> diff -u -p -r1.5.2.6 trap.c
> --- i386/i386/trap.c 11 Nov 2006 00:54:05 -0000 1.5.2.6
> +++ i386/i386/trap.c 15 Nov 2006 17:15:58 -0000
> @@ -60,6 +60,8 @@ extern void thread_exception_return();
> extern void i386_exception();
>
> #if MACH_KDB
> +#include <ddb/db_watch.h>
> +#include <ddb/db_run.h>
> boolean_t debug_all_traps_with_kdb = FALSE;
> extern struct db_watchpoint *db_watchpoint_list;
> extern boolean_t db_watchpoints_inserted;
The #includes should go at the front, with the rest of the <> includes.
Preserve the normal order:
#include <>
...
#include ""
...
other decls
...
functions
except when there is a good reason to deviate, which there does not seem
to be in this case.
Thomas
signature.asc
Description: This is a digitally signed message part