Re: [PATCH] Support for alignment in the zone allocator

[Thomas Schwinge]

Hello!

A happy new year to everyone!


On Sat, Dec 30, 2006 at 12:53:24PM +0100, Richard Braun wrote:
> Here is a patch that does it all. Any comments ?

As I told you already on irc, I think that the patch is fine.  If Samuel
(who needed this functionality, if I recall correctly) also agrees then
feel free to put it in.


> 2006-12-30  Richard Braun  <syn@hurdfr.org>
> 
>       Added alignment support in the zone allocator.
> 
>       * kern/zalloc.c (ALIGN_SIZE_UP): New macro.

No empty line here if only one block of changes is following.  In general
(also for Samuel): you don't have to write these introductory lines if it
is understandable from the following block of changes what the patch is
doing.  But it doesn't hurt either.  :-)

>       (zone_bootstrap): Updated call to zinit() with alignment of 0.

Move that one down to the other ``Likewise.'' ones, I'd suggest.


Also, while browsing through the GNU Mach code, I noticed that in
`kern/zalloc.c' the `zalloc_wasted_space' variabled is maintained without
any use.  Might this variable be useful for something?  If not, then feel
free to remove it.


Regards,
 Thomas

signature.asc
Description: Digital signature