Re: libtrivfs broken?

[Thomas Bushnell BSG]

On Tue, 2007-02-20 at 12:10 +0100, Richard Braun wrote:
> On Mon, Feb 19, 2007 at 05:21:29PM -0800, Thomas Bushnell BSG wrote:
> > On Tue, 2007-02-20 at 00:46 +0100, Richard Braun wrote:
> > > I understand the point. But calling file_getcontrol() on the upper-level
> > > node won't allow us to update the options of the trivfs translator AIUI.
> > > Isn't there a way to do that without being root ?
> > 
> > Yes it will; it will give you the fsys handle for the active translator:
> > the trivfs translator here; then you can call fsys_* on it.
> 
> I see, but it's not what fsysopts does anyway : it first calls
> file_name_lookup() to get a handle on the node and then
> file_getcontrol() on this handle. There is no way to make this call
> on the parent using fsysopts, is there ?

I don't know.  I agree completely that there is a bug, just that
changing trivfs seems like the wrong thing.  I think fsysopts should try
both ways to get the handle, since either one might work and not the
other.

Thomas

signature.asc
Description: This is a digitally signed message part