Re: weak _pthread_mutex_lock()

[Samuel Thibault]

Hi,

Thomas Schwinge, le Fri 27 Jul 2007 23:49:29 +0200, a écrit :
> As Neal told me that these inline functions are just an optimization
> which he copied (when writing libpthread) from Mark Kettenis' code,
> perhaps just removing them would already help?

I'd recommend that, yes. Having these optimizations right in all
cases (including static linking, where a weak symbol doesn't let
libpthread.a's pt-lock.o being included) seems tricky.  From a personal
point of view, I event find such static inlines in user-visible headers
a bit ugly :)

> Also, we should evaluate Bruno Haible's suggestions from
> <http://lists.gnu.org/archive/html/bug-hurd/2007-03/msg00102.html>.

The Hurd's glibc definitely needs these pthread hooks on the long run,
but the way it is done for nptl for instance requires the libpthread to
be in glibc (because the glibc hooks need to call a bunch of libpthread
functions).

Samuel