Re: Bug#440068: gnumach: GPT in fp_save, fpu.c:675

[Samuel Thibault]

Thomas Schwinge, le Wed 29 Aug 2007 22:44:06 +0200, a écrit :
> Why isn't that patch in upsteam cvs?  Does it need more testing (as this
> bug report might indicate)?

Well, the buildd tested it pretty well, and yes, this bug needs to be
fixed. Then it should be ok to commit. The MMX support is not complete
however: we need to extend the kernel/user get_state interface so that
gdb can fetch the mmx registers of another task for instance.

> > fnsave would be fine.
> 
> Also without the ``0 -> 16'' alignment patch?

Yes. fnsave doesn't have such alignment requirement.

> > > > looks like there is a bug somewhere in the alignment support of
> > > > zalloc().
> > > 
> > > Would this be a correct patch?
> > 
> > This is already in the debian package.
> 
> So it's a different bug.

?
Which bug is different from which bug?  The only bug I can see here is
that zalloc() doesn't always correctly align data.  0->16 is not in
upstream CVS because upstream CVS always uses fnsave, not fxsave, so
such alignment is not required there.  Debian's version uses fxsave, so
it is there (and 0->16 is hence already there).

Samuel