[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [task #6537] Implement ddb/db_elf.c

From: Andrei Barbu
Subject: Re: [task #6537] Implement ddb/db_elf.c
Date: Sun, 25 May 2008 02:07:36 -0400


Thanks for the comments.

> - take care of indentation. Try to respect the same existing indentation
>  (yes it's not homogeneous, follow it per-file). For instance, in
>  new-gnumach-3/i386/i386at/model_dep.c
Ah, sorry. My emacs automatically reindents every file to my settings,
I'll disable that.

> - use -p option of diff.

> - I'm not sure we want to instroduce the POSIX types.  Can't we just use
>  the Mach types in the ELF headers?  It looks like there aren't so many
>  occurences anyway.
I'd prefer to keep the headers unchaged. They're from FreeBSD and if
we don't make changes we can easily update to newer versions in the
future. POSIX types will help when stealing other parts of FreeBSD if
we choose to do so in the future, their ddb for example is far better
than ours.

> - I would have put __CONCAT in the ELF header, as it's the only place
>  where it is used.  Other helper macros aren't used.
Same as above.

> - in model_dep.c you can factorize the test for kern_sym_start.

> - please provide a GNU-style ChangeLog.

I'll send an updated patch tomorrow.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]