bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: The patch of glibc which allows the user to override the pfinet serv


From: zhengda
Subject: Re: The patch of glibc which allows the user to override the pfinet server
Date: Fri, 15 Aug 2008 20:05:53 +0200
User-agent: Thunderbird 2.0.0.16 (X11/20080707)

Samuel Thibault wrote:
zhengda, le Fri 15 Aug 2008 19:05:49 +0200, a écrit :
Samuel Thibault wrote:
zhengda, le Fri 15 Aug 2008 18:27:00 +0200, a écrit :
+      if (__asprintf (&name, "SOCK_SERV_%d", domain) < 0)
+    __libc_fatal ("hurd: Can't get the socket server path\n");
Shouldn't we just return ENOMEM?
In many parts of glibc, __libc_fatal() or assert() is used.

When there is no way to report the error, isn't it?
In the place where __libc_fatal() is called, you're right. They are usually the initialization routines. But for the case of assert(), I don't think so. make_hol() is an example. There are many cases in argp.

Zheng Da





reply via email to

[Prev in Thread] Current Thread [Next in Thread]