Re: The patch of boot to open a virtual network interface

[zhengda]

Ben Asselstine wrote:
> On Tue, Aug 19, 2008 at 4:02 PM, zhengda <zhengda1936@gmail.com> wrote:
>   
> > +    case 'f':
> > +      dev_file = strstr (arg, "=");
> > +      if (dev_file == NULL)
> > +       return ARGP_ERR_UNKNOWN;
> > +      *dev_file = 0;
> > +      add_dev_map (arg, dev_file+1);
> > +      break;
> >     
>
> I'd feel better about this patch if it used a long option --device
> instead of the short option -f.
>   
Do you mean the patch only provides the long option --device?
> Also, the use of strstr is pernicious.
>   
why? Is there any other function to do it? or should I write the loop to 
find '=' myself?

Zheng Da