Re: [PATCH] About the bug that makes pfinet crash

[Samuel Thibault]

Thomas Schwinge, le Mon 24 Nov 2008 11:43:58 +0100, a écrit :
> > > - if (count == 0 || count > PAGE_SIZE)
> > > + if (count < ifp->if_header_size ||
> > > +     count > ifp->if_header_size + ifp->if_mtu)
> > >           return D_INVALID_SIZE;
> > >  
> > >           assert(copy->type == VM_MAP_COPY_PAGE_LIST);
> > 
> > Mmm, the < should be fine, but I'd rather see the > still use PAGE_SIZE,
> > or perhaps replace these PAGE_SIZE occurrences with a macro defed to
> > PAGE_SIZE.
> 
> Or what about installing my change as given above, but also adding an
> ``assert (ifp->if_header_size + ifp->if_mtu <= PAGE_SIZE)''?

Why not indeed.

Samuel