bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 5/5] Changed argp parsing policy


From: olafBuddenhagen
Subject: Re: [PATCH 5/5] Changed argp parsing policy
Date: Sun, 31 May 2009 11:01:21 +0200
User-agent: Mutt/1.5.18 (2008-05-17)

Hi,

On Fri, May 29, 2009 at 12:09:04AM +0300, Sergiu Ivanov wrote:

> +/*---------------------------------------------------------------------------*/
> +#include "unionmount.h"
> +/*---------------------------------------------------------------------------*/
> +
> +/*---------------------------------------------------------------------------*/
> +/*---------Global 
> Variables--------------------------------------------------*/
> +/*The command line for starting the translator. */
> +char * trans_argz;
> +size_t trans_argz_len;
> +/*---------------------------------------------------------------------------*/
[...]

Please drop these crazy comment "lines"... I'm not going to discuss the
aesthetic value of such ornaments :-) -- but please try to keep
consistent with the style of the existing code.

Also, I don't think a comment saying "global variables" is exactly
useful -- this is really obvious to any C programmer...

-antrik-




reply via email to

[Prev in Thread] Current Thread [Next in Thread]