Re: [PATCH3/4] fully enable rpctrace to trace multitask programs.

[olafBuddenhagen]

Hi,

On Mon, Jul 20, 2009 at 07:42:20PM +0800, Da Zheng wrote:

> The third patch removes one of gcc's warnings.
> 
> Zheng Da
> 
> 
> 2009-07-20  Zheng Da  <zhengda1936@gmail.com>
> 
>       rpctrace.c (print_contents): Put the if statement in braces.
> 
> diff --git a/utils/rpctrace.c b/utils/rpctrace.c
> index 148b0a4..6d4801e 100644
> --- a/utils/rpctrace.c
> +++ b/utils/rpctrace.c
> @@ -634,10 +634,12 @@ print_contents (mach_msg_header_t *inp,
>               type->msgt_name = name;
>           }
>         else if (nelt > 0 && newtypes[0] != name)
> -         if (type->msgt_longform)
> -           lt->msgtl_name = newtypes[0];
> -         else
> -           type->msgt_name = newtypes[0];
> +         {
> +           if (type->msgt_longform)
> +             lt->msgtl_name = newtypes[0];
> +           else
> +             type->msgt_name = newtypes[0];
> +         }
>       }
>        else
>       print_data (name, data, nelt, eltsize);

This looks fine, aside from the commit message issue I already mentioned
for the other patch...

It is another change that is totally unrelated to tracing mutiple tasks
though, so should be submitted independently, not as part of the patch
series.

(Perhaps it would be useful to group all cleanup changes in another
patch series, if there is more than one...)

-antrik-