bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Apply pattern-matching immediately beneath the stow director


From: olafBuddenhagen
Subject: Re: [PATCH] Apply pattern-matching immediately beneath the stow directory.
Date: Mon, 7 Sep 2009 02:33:30 +0200
User-agent: Mutt/1.5.19 (2009-01-05)

Hi,

On Mon, Aug 31, 2009 at 11:32:12PM +0300, Sergiu Ivanov wrote:

> This patch makes unionfs try the pattern against the directories
> immediately beneath stow/ , instead of doing it in the original way.
> 
> Please note, however, that "*/bin" will not work anyways, because
> unionfs checks the patterns only against the first-level
> subdirectories of stow/ .

This is not acceptable.

If you change the behaviour in such a way that the main use case -- and
probably the only relevant one at that -- doesn't work anymore, you
could just as well rip it out alltogether...

> To make this pattern work, unionfs would have to traverse all
> subdirectories of stow/ , interpreting the pattern in a smart way and
> consuming much more time than it does now.

Well, not knowing how this stuff is handled, I can't tell: is it really
not possible to implement proper wildcard matching of more than the
first component efficiently? It's hard to imagine why an explicit '*'
should be so much more troublesome than the implied one in the original
implementation...

-antrik-




reply via email to

[Prev in Thread] Current Thread [Next in Thread]