[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/3] gnumach: Build system fixes

From: Thomas Schwinge
Subject: Re: [PATCH 0/3] gnumach: Build system fixes
Date: Tue, 17 Nov 2009 00:34:14 +0100
User-agent: Mutt/1.5.18 (2008-05-17)


Thanks for the patches!

On Sun, Nov 15, 2009 at 07:20:49PM +0100, Guillem Jover wrote:
> * config.status.dep.patch: Refresh.
> ---
> This is needed due to AM_SILENT_RULES.

Actually this is due to Automake 1.10.2 / 1.11 having had internal

> ---- config.status.save       2006-10-09 22:28:47.000000000 +0200
> -+++ config.status    2006-10-09 22:29:34.000000000 +0200

> +--- config.status    2009-10-26 23:57:14.000000000 +0100
> ++++ config.status.new        2009-10-27 00:04:26.000000000 +0100

So this worked fine for something like three years -- which I better than
what I had expected.  ;-)

I put this in.  If it breaks for someone who still has an older Automake
version, we can add a fall-back.

On Sun, Nov 15, 2009 at 07:19:29PM +0100, Guillem Jover wrote:
> * .gitignore: New file.

Generally, I don't like these ignore files too much.  But if you promise
to maintain this file (whatever this means -- no maintenance would have
been required in the last years, I guess), and take the rap should this
ever cause any harm due to hiding any files' changes, etc., then it can
go in.

On Sun, Nov 15, 2009 at 07:19:18PM +0100, Guillem Jover wrote:
> The silent
> rules enabled by default will make it easier to see warnings, even if
> currently you get easily drown by their quantity. If there's an error
> they can be temporarily disabled using “make V=1” or disabled for the
> whole build with “configure --disable-silent-rules”. Something I will
> be doing in the Debian package so that we get useful build logs.

Likewise, this functionality has probably already been the cause for many
men's wasted days discussing its pros and cons in other projects.  It can
go in with the following changes: ``default'' typo in the commit log;
please centralize all the *_V* definitions in one place: in Makefile.am,
as a new ^L ``page'' before the the ``MIG Setup'' section would be best,
I think.  (As a bonus, you could also already update the copyright

With these changes please either resend, or put into some Git branch on
Savannah -- I just added you to the group; welcome on board! -- the rules
are still to be found here:


Attachment: signature.asc
Description: Digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]