[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/3] gnumach: Build system fixes

From: Guillem Jover
Subject: Re: [PATCH 0/3] gnumach: Build system fixes
Date: Sat, 5 Dec 2009 23:15:33 +0100
User-agent: Mutt/1.5.20 (2009-06-14)


On Tue, 2009-11-17 at 00:34:14 +0100, Thomas Schwinge wrote:
> On Sun, Nov 15, 2009 at 07:20:49PM +0100, Guillem Jover wrote:
> > * config.status.dep.patch: Refresh.
> > ---
> > 
> > This is needed due to AM_SILENT_RULES.
> Actually this is due to Automake 1.10.2 / 1.11 having had internal
> changes.

Hmm that's what I thought initially, but AFAIR it only caused problems
when running autoreconf with the AM_SILENT_RULES, but I could

> I put this in.  If it breaks for someone who still has an older Automake
> version, we can add a fall-back.

I seemed to recall at some point you mentioned that this had been fixed
in newer automake versions, but the comments on the code didn't seem
to indicate so. If that's the case I'd vote to just remove the
patching logic and just require a newer automake, it's going to be
less painful overall.

> On Sun, Nov 15, 2009 at 07:19:29PM +0100, Guillem Jover wrote:
> > * .gitignore: New file.
> Generally, I don't like these ignore files too much.  But if you promise
> to maintain this file (whatever this means -- no maintenance would have
> been required in the last years, I guess), and take the rap should this
> ever cause any harm due to hiding any files' changes, etc., then it can
> go in.

As Olaf said, how do you make use of ‘git status’ otherwise? And I
cannot guarantee I'll be around to fix such problems, I might, but
also as Olaf said I think this should be the responsibility of the one
submitting/committing new stuff. But if you don't like it, that's also
fine, I'll just keep the patch locally.

(Just noticed that the ChangeLog entry is not indented with a tab.)

> On Sun, Nov 15, 2009 at 07:19:18PM +0100, Guillem Jover wrote:
> > The silent
> > rules enabled by default will make it easier to see warnings, even if
> > currently you get easily drown by their quantity. If there's an error
> > they can be temporarily disabled using “make V=1” or disabled for the
> > whole build with “configure --disable-silent-rules”. Something I will
> > be doing in the Debian package so that we get useful build logs.
> Likewise, this functionality has probably already been the cause for many
> men's wasted days discussing its pros and cons in other projects.  It can
> go in with the following changes: ``default'' typo in the commit log;
> please centralize all the *_V* definitions in one place: in Makefile.am,
> as a new ^L ``page'' before the the ``MIG Setup'' section would be best,
> I think.  (As a bonus, you could also already update the copyright
> years.)
> With these changes please either resend, or put into some Git branch on
> Savannah -- I just added you to the group; welcome on board! -- the rules
> are still to be found here:
> <http://www.bddebian.com:8888/~hurd-web/rules/source_repositories/>

Heh, thanks! I'm resending the fixed patch now.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]