bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Reauthentication implementation flaw due to EINTR


From: Carl Fredrik Hammar
Subject: Re: Reauthentication implementation flaw due to EINTR
Date: Tue, 29 Dec 2009 23:01:06 +0100
User-agent: Mutt/1.5.20 (2009-06-14)

On Mon, Dec 28, 2009 at 03:24:52AM +0100, Samuel Thibault wrote:
> Carl Fredrik Hammar, le Sun 27 Dec 2009 20:56:21 +0100, a écrit :
> > If the notification request is canceled before auth_user_authenticate
> > returns there should be no problem.
> 
> I tried a crude
> 
>           error_t err2 = mach_port_request_notification(mach_task_self(), 
> rendezvous, MACH_NOTIFY_DEAD_NAME, 0, MACH_PORT_NULL, 
> MACH_MSG_TYPE_MAKE_SEND_ONCE, &old);
> 
> after the complete if (hurd_condition_wait (&s.wakeup, &pending_lock)
> statement, with no luck: ext2fs got an EINTR anyway.

Err, shouldn't be in the user part after it finds the pending server if
we want to do it before auth_user_authenticate returns?

(I know you said something later about only testing this in the unpatched
version, but it should work in the unpatched version if the problem is
indeed the dead-name notification.)

Regards,
  Fredrik




reply via email to

[Prev in Thread] Current Thread [Next in Thread]