Re: Reauthentication implementation flaw due to EINTR

[Samuel Thibault]

Carl Fredrik Hammar, le Tue 29 Dec 2009 23:01:06 +0100, a écrit :
> On Mon, Dec 28, 2009 at 03:24:52AM +0100, Samuel Thibault wrote:
> > Carl Fredrik Hammar, le Sun 27 Dec 2009 20:56:21 +0100, a écrit :
> > > If the notification request is canceled before auth_user_authenticate
> > > returns there should be no problem.
> > 
> > I tried a crude
> > 
> >           error_t err2 = mach_port_request_notification(mach_task_self(), 
> > rendezvous, MACH_NOTIFY_DEAD_NAME, 0, MACH_PORT_NULL, 
> > MACH_MSG_TYPE_MAKE_SEND_ONCE, &old);
> > 
> > after the complete if (hurd_condition_wait (&s.wakeup, &pending_lock)
> > statement, with no luck: ext2fs got an EINTR anyway.
> 
> Err, shouldn't be in the user part after it finds the pending server if
> we want to do it before auth_user_authenticate returns?

That's the same.  To make it clearer, see attached patch.

Samuel

patch
Description: Text document