Re: [bug #28779] libstore/ext2fs issue with sparse store

[Carl Fredrik Hammar]

On Fri, Feb 05, 2010 at 11:30:17PM +0100, Samuel Thibault wrote:
> Carl Fredrik Hammar, le Fri 05 Feb 2010 22:28:00 +0000, a écrit :
> > In fact, it is impossible to map out the blocks of
> > a file hole without actually allocating the blocks,
> > which defeats the purpose of the hole.  Instead, I
> > think the right solution is to simply have ext2fs's
> > diskfs_S_file_get_storage_info fail if the file
> > contains holes, so that the client will use it
> > through the filesystem interface.
> 
> Will that be automatic?

The client will automatically use file_store if file_get_storage_info
fails, yes.  I'm not entirely sure which error code to fail with though.
We could also explicitly return a file_store.  I'm not sure which is
more proper.

Regards,
  Fredrik