[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #29655] linkat() fails because __file_name_lookup_at() problems

From: Carl Fredrik Hammar
Subject: [bug #29655] linkat() fails because __file_name_lookup_at() problems
Date: Sat, 08 May 2010 20:39:57 +0000
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100414 Iceweasel/3.5.9 (like Firefox/3.5.9)

Follow-up Comment #4, bug #29655 (project hurd):

This has already been said on IRC but I might as well repeat it here:
POSIX.1-2008 says that only `AT_SYMLINK_FOLLOW` is applicable to linkat()
(see http://www.opengroup.org/onlinepubs/9699919799/functions/linkat.html).
I would recommend testing it in `__file_name_lookup_at()` as I described
earlier.  Otherwise, you'd need to check it in all `at` functions
except `openat()', because they should fail when they're given

You are a bit too verbose in the ChangeLog, the first item is fine,
but the second item should just be "Updated comment."  or some such.
In the third item, you shouldn't mention motivation, i.e "Pass O_NOLINK
in flags" would be enough.  Such information should be placed in code
comments, as it already is.  Also there should be no blank lines between
related items, and they are all related:

    * item1 (foo): ...
    * item2 (bar): ...


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]