[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] mach_defpager: Fix external objects interface

From: olafBuddenhagen
Subject: Re: [PATCH] mach_defpager: Fix external objects interface
Date: Wed, 19 May 2010 10:17:00 +0200
User-agent: Mutt/1.5.19 (2009-01-05)


On Tue, May 18, 2010 at 04:19:10PM +0200, Sergio Lopez wrote:

> This patch fixes external objects interface in mach_defpager (current
> default pager in Hurd), so it can be used as backing store by other
> translators (like tmpfs).

I don't know enough about this code to actually understand the changes.
However, on a quick glance, there seem to be several unrelated fixes in
this patch?... Please split them into separate patches; and add a short
explanation to each.

> +      /* FIXME: Currently, we're unable to free used swap space 
> +      if (ds->dpager.size > ds->dpager.limit / vm_page_size)
> +        pager_truncate (&ds->dpager, ds->dpager.limit / vm_page_size);
> +      */

Don't comment out code -- use "#if 0" instead.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]