Re: [PATCH] Fix --version in scripts

[Carl Fredrik Hammar]

Hi,

On Wed, May 26, 2010 at 10:25:49AM +0200, olafBuddenhagen@gmx.net wrote:
> On Tue, May 25, 2010 at 10:49:16AM +0200, Carl Fredrik Hammar wrote:
> 
> > Emilio reported that `fakeroot --version' (fakeroot-hurd in Debian)
> > prints out `STANDARD_HURD_VERSION_uptime_' instead of its version. The
> > bug is due to a faulty make rule which depends on the original sed
> > script which inserted the correct version but was later inlined into
> > Makeconf itself (back in '99!). The bug also affects uptime and
> > mkfsimage.
> > 
> > Here's a patch which fixes this, and the actual sed script.
> 
> Looks fine to me. Should be applied to master.

Great!

Thomas, Samuel, could either of you apply it?

> > P.S. This message should apply correctly with `git am -c'.
> 
> Don't do that. Just put your remarks below the "---" line. While they
> will be passed to the patch command this way, "patch" ignores any junk
> at the beginnig. (Like the diffstat included by default.)

I guess I got a bit carried away with keeping the commit message closer
to the patch.  :-)

Regards,
  Fredrik