[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Check for rendezvous port death in auth server

From: olafBuddenhagen
Subject: Re: [PATCH] Check for rendezvous port death in auth server
Date: Wed, 2 Jun 2010 00:17:12 +0200
User-agent: Mutt/1.5.19 (2009-01-05)


On Tue, Jun 01, 2010 at 07:53:08PM +0200, Carl Fredrik Hammar wrote:

> This is a patch for the auth server to make it also return EINVAL when
> the rendezvous port has died during a transaction and not only if it
> is dead on arrival, as discussed earlier on IRC.
> This is probably not an important fix since a server should retry the
> RPC when it fails with EINTR and would then get EINVAL, and the user
> shouldn't have a problem since it is typically in control of the
> rendezvous port. Still, it is not impossible to come up with
> contrived, future situations where this could become a problem.
> Instead, my main motivation for doing this is just that it seems very
> sloppy of the auth server to rely on its client's behavior to make
> sure it eventually gets the correct error code.

I'm a bit ambivalent about this... On one hand, returning the right
error code right away is probably less confusing; but on the other hand,
it adds extra code paths (with all the associated disadvantages) for
something that just works in a natural fashion right now -- which in a
way is actually more elegant...

Perhaps just add comments in appropriate places (the actual code
returning the errors, and the RPC definitions) documenting the current

(Sorry for not bringing it up earlier; it only became clear in my mind
when I saw the actual code...)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]