[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 0/8] Bring console-driver-xkb up to date

From: Diego Nieto Cid
Subject: [PATCH 0/8] Bring console-driver-xkb up to date
Date: Wed, 4 Aug 2010 04:19:58 -0300

Dear list,

   The past couple of weeks I've been packaging Marco's input driver
for Arch Hurd and I've found that some changes were necesary to make
it work again.

   The patch series this message introduces is based on the Debian
source code (after applying patches) for version 0.008-7 of the

   Only the first patch is strictly necesary to be able to run the
input driver again [*]. The rest of them are bug fixes which were
affecting infrequently reached lines of code and other improvements.

   Patch number 5 copies some files from the hurd tree. I didn't
record the date, but they should be at least from the commit
80f1aefacad4e898434962acb1f1af62eb815ef8. Which misses a few recent
changes to the console-client. I don't know if this is required but
as I saw some shared header files, I thought it was a sensible thing
to update them. It may break things on older hurd builds, though.

   BTW, I don't like this source code duplication. When I saw that
most of the input driver is the same as pc_kbd it came to mind this
should actually be a libxkb used by pc_kbd. But I wanted to have
something working first. :)

   I'm not sure about patch number 3. There is a comment saying
something is dead code, aparently related to virtual modifiers.
Fixed them just in case, though.

   This mail is quite long, so thanks for having read it :)


[*]: Tested that under the debian hurd image dated 17042010 I've
downloaded from ~thibault's tmp folder at dept-info.labri.fr

  The list of patches:

    1. Update the parser to work with current XKB files.
    2. Avoid hashing garbage for short keynames.
    3. Rule vmod returns an int with the vmod's bit on.
    4. Remove glue code and use mig to regenerate it.
    5. Update code borrowed from console-client.
    6. Add missing functions to input_driver_test.
    7. Argument's default values are set independently.
    8. Use vfprintf in debug_printf and write to stderr.

 Makefile            |   67 ++++-
 input.h             |    3 +
 input_driver_test.c |   10 +
 inputdev.h          |    6 +-
 kdioctl.defs        |   39 +++
 kdioctlServer.c     |  192 -----------
 kdioctl_S.h         |   60 ----
 lex.l               |    3 +-
 parser.y            |   11 +-
 trans.c             |  892 +++++++++++++++++++++++++++++++++++++++++++++++++++
 trans.h             |   17 +-
 version.h           |   29 ++
 xkb.c               |   52 +++-
 xkb/keymap/hurd     |  294 ++++++++++--------
 xkbdata.c           |   14 +-
 15 files changed, 1279 insertions(+), 410 deletions(-)
 create mode 100644 kdioctl.defs
 delete mode 100644 kdioctlServer.c
 delete mode 100644 kdioctl_S.h
 create mode 100644 trans.c
 create mode 100644 version.h


reply via email to

[Prev in Thread] Current Thread [Next in Thread]