[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/8] Bring console-driver-xkb up to date

From: olafBuddenhagen
Subject: Re: [PATCH 0/8] Bring console-driver-xkb up to date
Date: Tue, 10 Aug 2010 00:35:11 +0200
User-agent: Mutt/1.5.20 (2009-06-14)


On Wed, Aug 04, 2010 at 04:19:58AM -0300, Diego Nieto Cid wrote:

>    The past couple of weeks I've been packaging Marco's input driver
>    for Arch Hurd and I've found that some changes were necesary to
>    make it work again.
>    Only the first patch is strictly necesary to be able to run the
>    input driver again [*]. The rest of them are bug fixes which were
>    affecting infrequently reached lines of code and other
>    improvements.

Great work, thank you! :-)

It is great in two ways actually. Obviously, it's great to have an
improved kbd driver. But it's also great to see that having another Hurd
distribution does indeed help overall Hurd development, as I hoped it
would :-)

>    Patch number 5 copies some files from the hurd tree. I didn't
>    record the date, but they should be at least from the commit
>    80f1aefacad4e898434962acb1f1af62eb815ef8. Which misses a few recent
>    changes to the console-client. I don't know if this is required but
>    as I saw some shared header files, I thought it was a sensible
>    thing to update them. It may break things on older hurd builds,
>    though.
>    BTW, I don't like this source code duplication. When I saw that
>    most of the input driver is the same as pc_kbd it came to mind this
>    should actually be a libxkb used by pc_kbd. But I wanted to have
>    something working first. :)

Indeed. I'm not really familiar with the situation; but it sounds like
xkb never should have been an extra driver, but rather just an update
(perhaps on a development branch) of the normal pc_kbd driver -- with
the xkb code simply replacing the old keymap handling...

(It could be controlled by an option -- but xkb is probably superior in
all regards; so I guess the old handling can be just replaced

Could you rework this accordingly? It should be rather straightforward I

(BTW, there is no need to put the xkb code in a library, as it won't be
used anywhere else.)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]