[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/8] Avoid hashing garbage for short keynames.
From: |
Carl Fredrik Hammar |
Subject: |
Re: [PATCH 2/8] Avoid hashing garbage for short keynames. |
Date: |
Sat, 14 Aug 2010 13:42:53 +0200 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
Hi,
On Wed, Aug 11, 2010 at 07:04:17PM -0300, Diego Nieto Cid wrote:
> Hi,
>
> 2010/8/9 <olafBuddenhagen@gmx.net>:
> >
> > Hm, why tmp[5]? The way I read the code, only 4 entries are used...
> >
>
> Well it's the null that terminates the string. But as this isn't used
> as a string it probably does not make much sense.
Not sure if this isn't already obvious to you but if it's not a string
then you should also use memcpy() instead of strncpy().
Regards,
Fredrik
- [PATCH 2/5] Lexer support for keycodes with +/- symbols and arbitrary level numbers., (continued)
- [PATCH 5/8] Update code borrowed from console-client., Diego Nieto Cid, 2010/08/04
- [PATCH 6/8] Add missing functions to input_driver_test., Diego Nieto Cid, 2010/08/04
- [PATCH 7/8] Argument's default values are set independently., Diego Nieto Cid, 2010/08/04
- [PATCH 8/8] Use vfprintf in debug_printf and write to stderr., Diego Nieto Cid, 2010/08/04
- Re: [PATCH 0/8] Bring console-driver-xkb up to date, olafBuddenhagen, 2010/08/11