Re: PATCH 2/2 - monitor backing store changes and update.

[olafBuddenhagen]

Hi,

On Wed, Apr 06, 2011 at 06:26:15PM +0100, Michael Walker wrote:

> > Missing Copyright/License header.
> 
> Ok, I wasn't entirely sure what to put as the xmlfs code I started
> with had HurdFR stuff, so I decided to leave it until I learned what
> the copyright situation for the xmlfs code is.

Well, by default, code you wrote yourself is always Copyright by you :-)
Though ideally you should assign copyright to the FSF of course, like
for most of the other Hurd code...

> > IIRC most Hurd code has a copy of the function documentation in the
> > .c file... Don't know about the existing xmlfs code though?
> 
> Hmm, I definitely need to look up commenting/documentation in the GNU
> coding style.

I'm not sure the GCS actually say anything about this. I *seem* to
remember though that it's the standard practice used in most of the Hurd
code. However, most of all you should try to be consistent with the
other xmlfs code I'd say... But I haven't checked myself how it handles
this, so it's a rather vague remark :-)

> > I believe this will leak a lot of stuff on each file change?
> 
> I'll definitely need to have a look at that. Almost certainly
> (developing seems so much harder with no valgrind to run after every
> change :P)

Indeed :-)

(As you probably know, we also have a Valgrind GSoC task... ;-) )

-antrik-