[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 04/15] Hurd signals: refactor check_pending_signals
|
From: |
Jérémie Koenig |
|
Subject: |
Re: [PATCH 04/15] Hurd signals: refactor check_pending_signals |
|
Date: |
Fri, 22 Jul 2011 16:37:36 +0200 |
2011/7/3 Jeremie Koenig <jk@jk.fr.eu.org>:
> On Sun, Jul 03, 2011 at 12:34:22AM +0200, Samuel Thibault wrote:
>> There is just one change that would be worth mentioning in the changelog:
>>
>> > - /* We "deliver" immediately pending blocked signals whose
>> > - action might be to ignore, so that if ignored they are
>> > - dropped right away. */
>> > - || ss->actions[signo].sa_handler == SIG_IGN
>> > - || ss->actions[signo].sa_handler == SIG_DFL))
>>
>> This is not done any more. Actually I believe it is more correct.
>
> Note that this example still does not terminate after the patch, because
> ignored signals are never actually marked pending:
>
> (hurd/hurdsig.c)
> | if (act != ignore && /* Signals ignored now are forgotten now.
> */
Dropped by the attached patch.
--
Jérémie Koenig <jk@jk.fr.eu.org>
http://jk.fr.eu.org/
no-sigign-special-treatment.diff
Description: Text Data