[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 15/17] Move cdrom_sleep() definition where it belongs
|
From: |
Samuel Thibault |
|
Subject: |
Re: [PATCH 15/17] Move cdrom_sleep() definition where it belongs |
|
Date: |
Sat, 27 Aug 2011 00:53:41 +0200 |
|
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Guillem Jover, le Thu 25 Aug 2011 15:22:38 +0200, a écrit :
> * linux/dev/kernel/sched.c (cdrom_sleep): Move to ...
> * linux/src/drivers/block/ide-cd.c: ... here, replace [!MACH]
> definition, and remove conditionals.
I disagree.
> void
> -cdrom_sleep (int t)
> -{
> - int xxx;
> -
> - assert_wait ((event_t) &xxx, TRUE);
> - thread_set_timeout (t);
> - schedule ();
> -}
This is really mach-specific glue code, so it should remain there or in
glue/
Samuel
- Re: [PATCH v2 02/17] Add silent rules support if available and disable it by default, (continued)
- [PATCH 14/17] Fix initialization from incompatible pointer type, Guillem Jover, 2011/08/25
- [PATCH 07/17] Add prototype for log function, Guillem Jover, 2011/08/25
- [PATCH 17/17] Initialize the new map entry when it's a projected buffer, Guillem Jover, 2011/08/25
- [PATCH 12/17] Disable unused variables, Guillem Jover, 2011/08/25
- [PATCH 15/17] Move cdrom_sleep() definition where it belongs, Guillem Jover, 2011/08/25
- Re: [PATCH 15/17] Move cdrom_sleep() definition where it belongs,
Samuel Thibault <=
- [PATCH 11/17] Remove unused variables, Guillem Jover, 2011/08/25
- [PATCH 10/17] Remove ident tags producing preprocessor warnings, Guillem Jover, 2011/08/25
- [PATCH 09/17] Add header for printf prototype, Guillem Jover, 2011/08/25
- [PATCH 13/17] Match signedness of char pointer comparisons and assignments, Guillem Jover, 2011/08/25