[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 15/17] Move cdrom_sleep() definition where it belongs
From: |
Guillem Jover |
Subject: |
Re: [PATCH 15/17] Move cdrom_sleep() definition where it belongs |
Date: |
Tue, 30 Aug 2011 02:43:03 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Sat, 2011-08-27 at 00:53:41 +0200, Samuel Thibault wrote:
> Guillem Jover, le Thu 25 Aug 2011 15:22:38 +0200, a écrit :
> > * linux/dev/kernel/sched.c (cdrom_sleep): Move to ...
> > * linux/src/drivers/block/ide-cd.c: ... here, replace [!MACH]
> > definition, and remove conditionals.
>
> I disagree.
>
> > void
> > -cdrom_sleep (int t)
> > -{
> > - int xxx;
> > -
> > - assert_wait ((event_t) &xxx, TRUE);
> > - thread_set_timeout (t);
> > - schedule ();
> > -}
>
> This is really mach-specific glue code, so it should remain there or in
> glue/
If the original file has to be modified anyway to disable the function
I don't see the point in arbitrarily moving the function somewhere
else, more so when it forces the function to be global when it should
be static. I agree that if a whole file needs writting from scratch
then the code belongs in glue/ in any file that makes sense.
I'm following up with a revised version of the patch, which makes it
easier to track modifications to the original. If you still do not
agree then I guess it would make sense to update ‘linux/dev/README’.
regards,
guillem
- [PATCH 14/17] Fix initialization from incompatible pointer type, (continued)
- [PATCH 14/17] Fix initialization from incompatible pointer type, Guillem Jover, 2011/08/25
- [PATCH 07/17] Add prototype for log function, Guillem Jover, 2011/08/25
- [PATCH 17/17] Initialize the new map entry when it's a projected buffer, Guillem Jover, 2011/08/25
- [PATCH 12/17] Disable unused variables, Guillem Jover, 2011/08/25
- [PATCH 15/17] Move cdrom_sleep() definition where it belongs, Guillem Jover, 2011/08/25
- [PATCH 11/17] Remove unused variables, Guillem Jover, 2011/08/25
- [PATCH 10/17] Remove ident tags producing preprocessor warnings, Guillem Jover, 2011/08/25
- [PATCH 09/17] Add header for printf prototype, Guillem Jover, 2011/08/25
- [PATCH 13/17] Match signedness of char pointer comparisons and assignments, Guillem Jover, 2011/08/25