[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Git write access for Guillem?

From: Guillem Jover
Subject: Re: Git write access for Guillem?
Date: Wed, 31 Aug 2011 14:28:02 +0200
User-agent: Mutt/1.5.21 (2010-09-15)


On Wed, 2011-08-31 at 12:53:56 +0200, Samuel Thibault wrote:
> Thomas Schwinge, le Wed 31 Aug 2011 12:49:40 +0200, a écrit :
> > Samuel has recently applied (thanks!) a ton of patches by/for Guillem
> > (thanks!); I'd be happy to allow Guillem to do the Git pushes himself
> > (after posting the patches on bug-hurd and getting them acknowledged).
> > Any comments?  (Or, Samuel, do you have any special/automated/time-saving
> > process for revieweing patches and the surrounding code, and
> > applying/committing them at the same time?)
> git am works perfectly in a blink of an eye. 99% of the time is review:
> understanding & testing.


Something though that would help in the review process would be to add
an explanation of why the change was done (like in normal git commit
messages), which sometimes does not fit in the Subject.

> Guillem could however commit himself indeed.

I've actually done so in the past [0], but I don't really mind either
way, whatever is easy for the maintainers I guess. Sometimes if some
patches from a series need to be redone then it might be easier for
the reviewer to push, for example.


[0] <http://lists.gnu.org/archive/html/bug-hurd/2009-12/msg00073.html>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]