Re: bug#10021: [PATCH id] Add error-checking on GNU

[Ludovic Courtès]

Hi Jim,

Jim Meyering <jim@meyering.net> skribis:

> Oh, I also had to make the new test script executable,
> or else "make check" would fail.

It works for me even if it’s not executable when I run “make check
TESTS=id/gnu-zero-uids”, apparently because it’s run this way:

  execve("/bin/sh", ["/bin/sh", "./shell-or-perl", "--test-name", 
"id/gnu-zero-uids", "--srcdir", ".", "--shell", "/bin/sh", "--perl", "perl", 
"--", "./id/gnu-zero-uids"], [/* 96 vars */]) = 0

It might be different when running just “make check”.

(I tested it on GNU/Linux and GNU/Hurd.)

> Since I've made so many changes, I'll wait to hear back
> from you before pushing it.

Looks good to me, thank you!

> +  test "$(uname)" = GNU \

So you’re assuming Bash, right?

Thanks,
Ludo’.