[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH,HURD] hurd: compliance fixes for getgroups

From: Roland McGrath
Subject: Re: [PATCH,HURD] hurd: compliance fixes for getgroups
Date: Mon, 14 May 2012 17:01:13 -0700 (PDT)

> > Since I see you already have
> > copyright paperwork and you're doing more than just the one change,
> > would you like to get set up to commit yourself?
> Given also my contributions so far, I guess that I should better need 
> review for now, no?

Everybody needs review.  Getting set up to do your own commits doesn't mean
you do them without approval, just that you can do the mechanical part
yourself instead of reviewers having to do it for you.  See the wiki.

This change looks fine to me.  Please follow the wiki instructions to get
set up to commit it yourself.  To make sure you're doing it right, don't
push to "master" but push it to a "<yourname>/<something>" private branch
as the wiki explains.  Then I'll double-check that you did everything right
and merge the branch in.  After that when I tell you a change is approved,
you can just push it directly to "master".


reply via email to

[Prev in Thread] Current Thread [Next in Thread]