Re: [PATCH,HURD] sendto: do not crash when addr is NULL

[Pino Toscano]

Hi,

Alle lunedì 21 maggio 2012, Roland McGrath ha scritto:
> Put the name of a local variable in all caps when mentioning it in
> the log entry or comments.

Noted, and done.

> It looks like the existing code also has a leak of APORT in the case
> where HURD_DPORT_USE fails (i.e. invalid fd).  So you should
> reorganize in some way that fixes that too.

Done.

> It might be simplest just to move the creation of the address port
> (both the AF_LOCAL case and the default case) into a subroutine and
> just call that inside HURD_DPORT_USE.  It means that the descriptor
> structure and port are kept alive around the AF_LOCAL case's calls,
> but that seems OK.

Done.

Updated patch attached.

-- 
Pino Toscano

hurd_sendto.diff
Description: Text Data

signature.asc
Description: This is a digitally signed message part.