[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH,HURD] sendto: do not crash when addr is NULL
|
From: |
Roland McGrath |
|
Subject: |
Re: [PATCH,HURD] sendto: do not crash when addr is NULL |
|
Date: |
Fri, 20 Jul 2012 09:59:50 -0700 (PDT) |
> Hm ok, I saw other cases of shadowing by internal subroutines, and
> assumed it was okay (since inside them you want to refer to the local
> "err" instead of the outermost one.
It's not the worst thing ever, and we don't compile with -Wshadow.
But shadowing is usually a good thing to avoid just to make reading
the code easier to follow.
Thanks,
Roland