Re: [PATCH] procfs: another fix for the process file name in stat/status

[Samuel Thibault]

Pino Toscano, le Mon 10 Sep 2012 17:31:32 +0200, a écrit :
> Alle domenica 9 settembre 2012, Samuel Thibault ha scritto:
> > Pino Toscano, le Fri 07 Sep 2012 20:02:56 +0200, a écrit :
> > > +static int args_filename_length (const char *name)
> > > +{
> > > +  const char *p = name;
> > > +  while (*p != '\0' && *p != ' ')
> > > +    ++p;
> > 
> > Why not using index(name, ' ') here?
> 
> If I would use strchr, the code would be something like:
>   const char *p = strchr (name, ' ');
>   return p != NULL ? p - name : strlen (name);
> which, for the common case, would mean scanning the string twice.

Ah, right. You can use strchrnul instead.

Samuel