Re: [PATCH] gnumach: configure: add --with-version-suffix=STRING

[Thomas Schwinge]

Hi!

On Mon, 1 Oct 2012 19:59:35 +0200, Pino Toscano <toscano.pino@tiscali.it> wrote:
> Alle giovedì 27 settembre 2012, Thomas Schwinge ha scritto:
> > On Mon, 24 Sep 2012 02:04:05 +0200, Guillem Jover 
> <guillem@hadrons.org> wrote:
> > > On Mon, 2012-09-24 at 00:30:39 +0200, Pino Toscano wrote:
> > > > Alle lunedì 24 settembre 2012, Thomas Schwinge ha scritto:
> > > > > Is --with-version-suffix the standard name for this option?
> > > > 
> > > > No idea, to be honest :)
> > > 
> > > I don't think there's any such standard name for this.
> > 
> > Right, probably not too wide-spread.  GCC has:
> > 
> >       --with-pkgversion=PKG   Use PKG in the version string in place
> > of "GCC"
> > 
> > Without setting that:
> > 
> >     i686-pc-gnu-gcc (GCC) 4.7.0 20110905 (experimental)
> > 
> > With setting it:
> > 
> >     gcc (Debian 4.7.1-7) 4.7.1
> > 
> > (Search for case-insensitive pkgversion in config/acx.m4,
> > gcc/Makefile.in, gcc/toplev.c, gcc/version.c.)  Would that seem
> > reasonable for GNU Mach, too?
> 
> It is not the same thing, --with-pkgversion replaces only the part 
> inside the brackets, but it does not affect the actual version.

Well, my implied question was whether that might be deemed appropritate
for GNU Mach, too: »gnumach (Debian 1.3.99.dfsg.git20110227-1) 1.3.99«.
If not...

> I updated the patch as said above.

..., then this patch is OK.


Grüße,
 Thomas

pgpMMOLefX6rT.pgp
Description: PGP signature