[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH.HURD] fix fdatasync/fsync if file_sync is not supported

From: Roland McGrath
Subject: Re: [PATCH.HURD] fix fdatasync/fsync if file_sync is not supported
Date: Thu, 25 Oct 2012 09:49:51 -0700 (PDT)

We don't generally handle MIG_BAD_ID.  That error indicates a server not
implementing the protocol for which it's being used, which is a server bug.
If anything, we'd translate that to EGRATUITOUS in the general case, and
perhaps to EOPNOTSUPP in particular cases where it's not an ironclad part
of the interface contract that it implement the particular protocol.  So I
think we should separate the MIG_BAD_ID case and treat it more generally,
if at all.

Since it's the norm for servers to return EOPNOTSUPP for miscellaneous RPCs
they aren't implementing, translating that to EINVAL for fsync/fdatasync is
reasonable.  It should have a comment saying that POSIX.1 specifies EINVAL
for a file descriptor on which sync is not supported.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]