Re: Questions about patches for hurdselect.c

[Samuel Thibault]

Svante Signell, le Fri 07 Dec 2012 17:13:00 +0100, a écrit :
> In the works of rewriting hurdselect.c I have some question on how to
> write patches. The changed code contains three parts:
> 1) Introducing three cases: DELAY, POLL, and SELECT

Why three cases? Isn't there a lot of common code between poll and
select?

> Doing the first part makes a diff with the original code not so useful,

But it does not change the semantic, right?

Your goal should be to make patches both readable and not introduce a
regression. Splitting patches into 3 to make it more readable while
keeping no regression when applying only one or two of them is
completely fine.

> Q1) Should I still send the new code in patch format?

It's probably more easily reviewable than brand new code.

> Q2) Should there be three patches, one for each change?

If that makes it more readable, yes.

> Q3) Part 3) is not yet finished, Should I wait until it is complete?

No. Submit your work early, that'll save you work if you have to go back
to change things.

Samuel