bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH,HURD] hurdselect: Step1, code split preparations


From: Svante Signell
Subject: Re: [PATCH,HURD] hurdselect: Step1, code split preparations
Date: Tue, 22 Jan 2013 19:49:35 +0100

On Tue, 2013-01-22 at 19:15 +0100, Pino Toscano wrote:
> Hi,
> 
> Alle martedì 22 gennaio 2013, Svante Signell ha scritto:
...
> >             const int fd = (int) d[i].io_port;
> >  
> > -           if (fd < _hurd_dtablesize)
> > -             {
> >                 d[i].cell = _hurd_dtable[fd];
> >                 d[i].io_port = _hurd_port_get (&d[i].cell->port,
> > &d[i].ulink); if (d[i].io_port != MACH_PORT_NULL)
> >                   continue;
> > -             }
> 
> why is this check removed? When collecting inputs from poll,
> d[i].io_port is the fd passed, which has no guarantee to be lower than
> _hurd_dtablesize.

That was a mistake. It should not be removed. Updated patch will follow
shortly.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]