Re: [PATCH,HURD][RFC] hurdselect: Step7x, almost complete rewrite finished

[Samuel Thibault]

Svante Signell, le Tue 12 Feb 2013 09:09:25 +0100, a écrit :
> Attached is a patch wrt the latest patch (step2) on January 24 2013. The
> indentation is different, therefore the diff blocks are a little large
> (but easier to read). Hopefully this is better. Including also the
> resulting file hurdselect_step7x.c. Explanations later in a separate
> mail.

Explanations don't need to be very long. All we need is the rationale
and the way you handle it in the patch.

AIUI, there are three things:

- pass 1ms as timeout. This will be fixed by Richard's patch.
- in the poll() case, do not fail completely if an FD is bogus. Instead,
  poll on the remaining FDs, and later on set POLLNVAL. It seems your
  patch does this by using the i_index array indirection.
- in the poll() case, on error returned by io_select, instead of setting
  readiness, set POLLHUP or POLLERR according to the error.

Is that right?

Samuel