Re: [PATCH,HURD] Fix reading core

[Thomas Schwinge]

Hi!

On Tue, 9 Apr 2013 16:41:17 -0700, Joel Brobecker <brobecker@adacore.com> wrote:
> > The i386 GNU/Hurd ELF core format actually follows the uaccess gregset_t
> > array format, not the Mach thread state format.  This fixes gdb reading
> > it.
> > 
> > * gdb/i386gnu-nat.c (CREG_OFFSET): New macro.
> > (creg_offset): New array.
> > (CREG_ADDR): Use creg_offset instead of reg_offset.
> 
> Did anyone review this? I don't know GNU/Hurd, but the patch looks
> very plausible.

Not yet, but it's on my list... (together with other Hurd GDB work).
Anyway, Joel, thanks for following up on Samuel's patch, and not letting
it fall through the cracks!


> Do you have write access to the GDB repository? If not, do you have
> copyright assignment papers on file? This patch is small enough that
> we can take it as a tiny patch, but if you think you're going to
> send more patches, we should probably get you started on those.

I'd support all that; Samuel's not on file for GDB (but is for other
packages, such as Hurd proper).


Grüße,
 Thomas

pgp3H9YLXksdo.pgp
Description: PGP signature