Re: [PATCH] gnumach/ddb: rewrite db_expr.h and remove trivial function from db_expr.c

[Samuel Thibault]

Marin Ramesa, le Mon 01 Jul 2013 12:37:54 +0200, a écrit :
> I don't know if this qualifies as a rewrite of db_expr.h; in my mind it 
> does, so I removed the copyright;

Well, the patch doesn't make it look so :)

> I completely removed calls to db_expression. I think it is a trivial 
> function; it just complicates things. 

Well, yes and no.

> -int
> -db_expression(valuep)
> -     db_expr_t *valuep;
> -{
> -     return (db_logical_or_expr(valuep));
> -}

This function makes a lot of sense grammar-wise. And the fact that
the Or operator is the most external operator of expressions is not
something we want to expose outside db_expression().

Samuel